Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-11035] Plugins specify a verion-range, slots just a version. #4

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

rburema
Copy link
Member

@rburema rburema commented Sep 15, 2023

This plugin doesn't work with the current system for now, will fix that later. Until then, this is a draft PR. (If you find this PR later, and the plugin works, it's most likely safe to delete this.)

Not the other way around as we have now. This also adheres closer to the way we handle front-end plugins. Ideally you'd maybe want both of them to be ranges, but that's for the future.

rburema and others added 2 commits September 15, 2023 14:09
Not the other way around as we have now. This also adheres closer to the way we handle front-end plugins. Ideally you'd maybe want both of them to be ranges, but that's for the future.

part of CURA-11035
@jellespijker jellespijker marked this pull request as ready for review September 20, 2023 05:41
Copy link
Member

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested on this plugin, but once we make this work again with the latest changes to the plugins architecture it should work

@jellespijker jellespijker merged commit 613a26f into main Sep 20, 2023
6 of 7 checks passed
@jellespijker jellespijker deleted the CURA-11035_invert_version_range branch September 20, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants